Fix issue preventing find_duplicates delete from working because of missing IDs

[joeyparis]

This fixes #2. Using keep = :first is faster than using :last because it doesn't need to get the count of the duplicates before selecting the ids.

[westonganger]

@joeyparis thanks for fixing this. I know we dont have any tests for this so far. But would you be able to add a few test cases so we can be ensured this method is working.

[joeyparis]

I can give it a shot!

On Mon, May 22 2023 at 8:46 PM, Weston Ganger @.***> wrote:

@joeyparis https://github.com/joeyparis thanks for fixing this. I know we dont have any tests for this so far. But would you be able to add a few test cases so we can be ensured this method is working.

— Reply to this email directly, view it on GitHub https://github.com/westonganger/rearmed_rails/pull/3#issuecomment-1558284632, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKQJDSMOIZET7UYTRBI4G3XHQCGBANCNFSM6AAAAAAYGXO2UA . You are receiving this because you were mentioned.Message ID: @.***>

[westonganger]

@joeyparis awesome thanks hopefully we can get this merged soon then.