paper_trail-association_tracking icon indicating copy to clipboard operation
paper_trail-association_tracking copied to clipboard

Has many reification is broken when custom version association name is set

Open stahor opened this issue 3 years ago • 1 comments

https://github.com/westonganger/paper_trail-association_tracking/blob/015422c567f75b6b8de708312b5dc9b7da143437/lib/paper_trail_association_tracking/reifiers/has_many.rb#L104 The line above leads to errors as soon as you customize the version association name. It tries to join ::PaperTrail::VersionAssociation to some a wrong association (e.g. my_custom_version) while it must be just joins(:version) https://github.com/westonganger/paper_trail-association_tracking/blob/015422c567f75b6b8de708312b5dc9b7da143437/lib/paper_trail_association_tracking/version_association_concern.rb#L10

stahor avatar Oct 12 '21 11:10 stahor

Ok would you consider creating a PR with test cases for this?

westonganger avatar Oct 13 '21 19:10 westonganger