performer icon indicating copy to clipboard operation
performer copied to clipboard

Per-step gate *negative* offset

Open hotelbachelard opened this issue 4 years ago • 5 comments

Hi,

I'd love to be able to do a negative gate offset on a step. Currently you can only go between 0 and 87. 5%, but you can't make the step trigger earlier. The screen also puts the 0% mark in the middle, so I assumed that you can go to negative values.

Many thanks!

hotelbachelard avatar Nov 26 '20 17:11 hotelbachelard

Hi, I have a PR with negative offsets implemented and I need some help testing it, would you mind trying my changes? https://github.com/westlicht/performer/pull/234

vafu avatar Dec 01 '20 01:12 vafu

Hey there, Sure! Thanks for asking

---------------Music: http://www.bachelard.bandcamp.com

On Monday, November 30, 2020, 8:13:34 p.m. EST, vafu <[email protected]> wrote:  

Hi, I have a PR with negative offsets implemented and I need some help testing it, would you mind trying my changes out? #234

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

hotelbachelard avatar Dec 01 '20 01:12 hotelbachelard

Hey @vafu - your latest version has a glitch. In the Step mode/page, normally, you can only turn on/off a step gate when you're on the Gate menu/page (1st tab, 1st item), and you need to press on the step + encoder when you're on any other menu (Retrig, Note, etc). But with your latest version, you can activate gate on/off from any page. Not sure if that's what you want - I personally prefer to be able to alter the gate sequence only in the Gate menu, so it's harder to accidentally alter the gate pattern while I'm trying to just change note values or gate lengths, etc.

I reloaded the official 0.1.39 firmware to confirm, because that's what I remember, and confirm that's the case.

hotelbachelard avatar Dec 06 '20 20:12 hotelbachelard

@hotelbachelard yes, thanks! I've added this as my own preference but I accidentally added these changes to the firmware update, sorry about that, I'm going to remove that asap!

vafu avatar Dec 06 '20 23:12 vafu

Hey @vafu - I found a lil bug in your 1.39: the Gate Probability bar doesn't show up in your version. :( 20210227_212900 it's there in 1.40 (and the official 1.39) 20210227_213108

hotelbachelard avatar Feb 28 '21 02:02 hotelbachelard