flex
flex copied to clipboard
westes
Is there any reason to keep tests/tableopts.am?
https://github.com/westes/flex/blob/master/tests/tableopts.am is always recreated if it is missing using the quite simple https://github.com/westes/flex/blob/master/tests/tableopts.sh (no additional tools needed),
As I want to change tableopts.sh I'd like to ask if I have permission to delete tableopts.am with a PR on the way or if there's a reason to keep this in the git repo.
Yes.
When autotools are run from autogen.sh, tableopts.am needs to be present. The only way to manage that is to track tableopts.am in version control.
On Friday, 14 September 2018, 2:44 pm +0000, Simon Sobisch [email protected] wrote:
https://github.com/westes/flex/blob/master/tests/tableopts.am is always recreated if it is missing using the quite simple https://github.com/westes/flex/blob/master/tests/tableopts.sh (no additional tools needed),
As I want to change tableopts.sh I'd like to ask if I have permission to delete tableopts.am with a PR on the way or if there's a reason to keep this in the git repo.
-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/westes/flex/issues/382
-- Will Estes [email protected]
When autotools are run from autogen.sh, tableopts.am needs to be present. The only way to manage that is to track tableopts.am in version control.
What about just running tests/tableopts.sh before running autotools in autogen.sh? This would "of course" be included in the PR.
I have some vague memory that there was an issue with that, but I can't recall anything specific enough to raise an objection.
Certainly try it and see what happens.
I do "git clean -xdf" if I'm working in my own working directory to make sure everything is gone. Or running it from a fresh checkout would of course make sure that you're starting from scratch which is the state that needs testing.
On Friday, 14 September 2018, 8:02 am -0700, Simon Sobisch [email protected] wrote:
When autotools are run from autogen.sh, tableopts.am needs to be present. The only way to manage that is to track tableopts.am in version control.
What about just running
tests/tableopts.shbefore running autotools in autogen.sh? This would "of course" be included in the PR.-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/westes/flex/issues/382#issuecomment-421386986
-- Will Estes [email protected]
@GitMensch Ideally we should let tests/tableopts.sh run during the running the autotools, or at least not later than ./configure. Forcing another step before autoreconf would be looking for trouble when usability is considered. You may try experiment with that and find a way to let tests/tableopts.sh done in the aforementioned phases. What I'm saying is that adding another step before autoreconf would be unwise and that's it.
Yes, if it's going to work, it would fit best in autogen.sh
On Sunday, 16 September 2018, 12:23 am -0700, Simon Sobisch [email protected] wrote:
@Explorer09 it will be done during autogen.sh, I think this is enough.
-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/westes/flex/issues/382#issuecomment-421715028
-- Will Estes [email protected]