flex generated scanners do not work on old compilers since 2.6

[GitMensch]

Just stumbled over this old bug when trying to compile the testsuite with the winbisonflex fork and using the local outdated VC2008 to compile the sources.

The "bad" commit is https://github.com/westes/flex/commit/71e207c1ac1bb664326a5539d93a022bf0deade9

because with this we "do" actual code (void)func() and define variables afterwards without opening a new branch {}. To fix this all those changes have to be revisited and the void's moved after the declaration.

I think I'll fix this like here

and create a PR. Is there something I should watch out for?

[GitMensch]

@westes / @Explorer09 If no one objects to likely include the code change I'll do those changes and PR (the left one in the sample above is the "fixed" version)

[westes]

Always submit a pr. There's no code to evaluate until that happens.

On Sunday, 16 September 2018, 6:46 am -0700, Simon Sobisch [email protected] wrote:

@westes / @Explorer09 If no one objects to likely include the code change I'll do those changes and PR (the left one in the sample above is the "fixed" version)

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/westes/flex/issues/381#issuecomment-421768009

-- Will Estes [email protected]