zenfs icon indicating copy to clipboard operation
zenfs copied to clipboard

Should we add an UT directory in zenfs repo?

Open royguo opened this issue 3 years ago • 6 comments

Current we don't have enough UT to cover all functions, I think we should start working on better UT pipeline

royguo avatar Jan 06 '22 03:01 royguo

I fully agree. I would suggest Boost.Test as a test harness, since we already include boost in the project.

metaspace avatar Jan 06 '22 10:01 metaspace

I fully agree. I would suggest Boost.Test as a test harness, since we already include boost in the project.

Is it possible to reuse RocksDB's gtest?

royguo avatar Jan 07 '22 03:01 royguo

We should try to use whatever rocksdb uses. A while ago I did look into the rocksdb unit testing to extend them for zenfs use, and gtest is a nice framework. Did not have time to add any tests, but now is a good time. @metaspace : do you see any issues using gtest?

yhr avatar Jan 10 '22 07:01 yhr

@royguo @yhr for sure lets reuse google test if infrastructure is already in place for rocksdb.

metaspace avatar Jan 10 '22 09:01 metaspace

@royguo : Do you have a shortlist of test you would like to have?

yhr avatar Jan 18 '22 08:01 yhr

I started preliminary work on test infrastructure in #172

metaspace avatar Mar 09 '22 19:03 metaspace

We'll need to rebase and extend the testing framework to make it useful. Let's do that when we add a significant amount of functionality. I've parked the code for now inhttps://github.com/westerndigitalcorporation/zenfs/tree/unit-tests

yhr avatar Oct 27 '23 08:10 yhr