wesnoth icon indicating copy to clipboard operation
wesnoth copied to clipboard

wmlunits: recognise the `add_advancement` key

Open stevecotton opened this issue 3 years ago • 2 comments

Describe the desired feature

@knyghtmare pointed out on Discord that units.wesnoth.org ignores customised advancements, so the eras/factions appear a bit broken in some cases.

It seems data/tools/unit_tree/helpers.py supports the deprecated [advancefrom] tag, but not its replacement [add_advancement]. It's not as simple as a renamed tag, because the new tag is now part of [campaign] rather than part of a [unit].

stevecotton avatar May 22 '22 13:05 stevecotton

because the new tag is now part of [campaign]

Not just that. It's part of

  1. [campaign]
  2. [modification]
  3. [era]
  4. [scenario]

I always thought the UWO was written entirely with Javascript. This is the first time I am seeing it is actually made with a python script.

knyghtmare avatar May 22 '22 13:05 knyghtmare

Just noting that (as stated on the linked page), add_advancement is the name of a key. The tag containing it is called [modify_unit_type].

CelticMinstrel avatar May 22 '22 14:05 CelticMinstrel