pandas2
pandas2 copied to clipboard
Code review tools for libpandas
I don't think GitHub can support the level of code scrutiny that we're going to want as part of the pandas 2.0 development process, particularly for C/C++ code that may need to go through multiple rounds of iterations.
Once we get going on the work, I'd suggest we give Gerrit a trial run, maybe via Gerrithub (which I haven't tried, but interested in doing -- have used Gerrit itself quite a bit with good experience), but we can also set up a dedicated instance on a VM (Linode, Digital Ocean) if needed
http://gerrithub.io/
The benefits of Gerrit IMHO are:
- much more transactional code reviews
- easier to review incremental changes to a PR
- much easier to examine individual comments and see the work that was done to to address that comment
- easier for the developer / PR author(s) to mark comments as fixed (the code reviews start feeling like a TODO list)
More reading: https://www.beepsend.com/2016/04/05/abandoning-gitflow-github-favour-gerrit/
I keep on waiting for GitHub to figure this out. They've made some progress, but it's still pretty bad...