wesleytodd
Add support for regex wildcard group
Looking at Route Paths in https://expressjs.com/en/guide/routing.html, Express supports routes such as /ab?cd and /ab*cd; however, when trying to implement /ab/cd(*) (which is mentioned in this issue), you would receive the following error: Invalid regular expression: /^(?:*)$/i: Nothing to repeat. This PR should fix that error.
@Megapixel99 can you give me a ping when you are comfortable with this PR and I can dig in and prepare a release?
@Megapixel99 can you give me a ping when you are comfortable with this PR and I can dig in and prepare a release?
@wesleytodd I believe this PR is good to go. If you want me to test it further (beyond the tests I wrote for it and the app I intend to use this feature in) before you merge let me know.
Sorry I have been super busy trying to get express v5 wrapped up. I will loop back on this soon after we release though. Is that alright? or is this blocking you? Because I trust you and the tests, so I can push a release if you are blocked on this.
Sorry I have been super busy trying to get express v5 wrapped up. I will loop back on this soon after we release though. Is that alright? or is this blocking you? Because I trust you and the tests, so I can push a release if you are blocked on this.
@wesleytodd I do not not need this to be merged right away. I can use the branch for the specific project which requires this feature for now.
If you need help with express v5 let me know. At one point you mentioned making me a commiter on the express project (https://github.com/wesleytodd/express-openapi/pull/54#issuecomment-1967211137) and I am happy to contribute earlier than anticipated.
Sorry, I had fallen so far behind in notifications I never saw this. You are very welcome to join us over there, we have a ton of work to do this year and a bunch of docs on how to get involved. The easiest way is probably to start with our triage team.
Anyway, I think this is a good change to support v4, but I think we need a bunch of changes to support v5. I am going to start working through that problem and hopefully will land this PR and then get v5 support as well before the next release.