Wesley Cho comments

Results 80 comments of


                                            Wesley Cho

maxDate and minDate not working on Date picker popup

One shouldn't put all that information in the view - it's an antipattern. It also was responsible for significant complexity internally in the datepicker, as well as limiting/triggering bugs in...

maxDate and minDate not working on Date picker popup

I understand, we sort of are dealing with limitations in Angular 1 here unfortunately. A little more verbosity isn't terrible for better separation/cleaner templates IMO.

uib-dropdown - ontoggle event not fired with multiple dropdowns on one page

The problem manifests if at least two dropdowns are in the same container - in this case, both are using `append-to-body`, so they have the same parent element. This would...

Popovers are closed even if popover-trigger is 'none'

This sounds like an easy feature - a PR would be good

Popovers are closed even if popover-trigger is 'none'

Ah sorry - I think `triggers === 'none'` might do the job.

Datepicker popup UTC Timezone issue

@noullet this sounds correct - pushing change shortly.

Datepicker popup UTC Timezone issue

Reopening to investigate.

Please reopen issue 3019

Going to leave the prior issue closed, as that proposal IMO doesn't provide the most extensibility - however, I would be open to exposing `openedWindows` publicly in the $modalStack service...

Break up timepicker's model into separate values

I'm a fan of using an object (second option), that way it is a nice & expected structure, and simple enough for a user to work with (i.e. modifying a...

[datepicker] active state on every first day of the month

I would say this is a minor UX bug since if you select any other date and then navigate, the active behavior does not trigger. PRs fixing this are welcome.