New opts not updated! WIP?

[AmeyV05]

Hi,

I am using UTide for python for sometime now! And I have noticed that all the kwargs are not yet available. For instance, if I run the solve function with nodiagn as an argument it runs into error.

I am guessing this is probably due to the newopts dictionary which is still a TODO?

Thanks and Regards, Amey

[efiring]

Why do you want to set nodiagn? All it does is prevent two quick calculations, for potential energy and SNR, from being done and their results included in the output array. Used internally, it is 0 unless conf_int is set to "none". I would prefer to eliminate it even internally, as part of a general simplification and phasing out of unnecessary internal options. (Among other things...)

[AmeyV05]

Understood!! I was not very clear before. So, I am experimenting with different options and what they do! And I realised that some of the options in the documentation were not available in the python code. The nodiagn option was just an example.

The current goal of my experimentations is to obtain R^R rayleigh criterion in the diagn output. That way, I wanted to test both SNR and Rayleigh criterion to find out the correct tidal constituents. Of course, I can always check the Rayleigh criterion separately, but since UTide already gives that as on output, it would save me some time.

P.S. I love UTide. It's such a nice package with a plethora of output options!

[sspagnol]

Is it due to 'nodiagn' not being defined in default_opts in _solve.py and using strict=True option to update_values method?

[efiring]

@sspagnol, yes, that's the mechanism. The default_opts dictionary includes all options intended to be exposed.