Wesley Barroso Lopes comments

Results 199 comments of


                                            Wesley Barroso Lopes

Use default query in SSR rendering and client fetch of the listing block when we don't have a search criteria

This PR fix yet another problem that occurs today. Today, if you create a listing block without filling in the search criteria and save, it will return the contents of...

Use default query in SSR rendering and client fetch of the listing block when we don't have a search criteria

> the folder content items now receive more brain data, there's an extra request on all folder contents. @tiberiuichim current templates work fine with basic metadata. Then we can change...

Use default query in SSR rendering and client fetch of the listing block when we don't have a search criteria

I saw a problem with this implementation. When we are going to add new content, the [initialPath](https://github.com/plone/volto/blob/0f459fed33d72826696c1aae5bb40f220485acb4/src/components/manage/Blocks/Listing/withQuerystringResults.jsx#L33) will be the current folder, since the content we are adding has not...

Use default query in SSR rendering and client fetch of the listing block when we don't have a search criteria

@pnicolli It seems the issue has been fixed, but not for all situations. See @mliebischer' comment: https://github.com/plone/volto/issues/3839#issuecomment-2637410384 I think the way it is here would fix those problems. So I...

Use default query in SSR rendering and client fetch of the listing block when we don't have a search criteria

> @wesleybl would you please resolve the conflicts and push? Thank you! @stevepiercy I fixed the conflicts and updated the branch. I also fixed https://github.com/plone/volto/pull/3866#issuecomment-1428193405 by testing inside `useDeepCompareEffect`.

Use default query in SSR rendering and client fetch of the listing block when we don't have a search criteria

@stevepiercy @sneridagh @pnicolli I updated the branch and fixed the tests. It's ready for review.

Use default query in SSR rendering and client fetch of the listing block when we don't have a search criteria

> All breaking changes must have an entry in the [Upgrade Guide](https://6.docs.plone.org/volto/upgrade-guide/index.html), per https://6.docs.plone.org/volto/contributing/index.html#document-breaking-changes I still have doubts about whether this is a breaking change. The way of doing search...