growi-docker-compose icon indicating copy to clipboard operation
growi-docker-compose copied to clipboard
verified publisher icon weseek

use multi stage build

Open inductor opened this issue 2 years ago • 3 comments

inductor avatar Jan 31 '23 02:01 inductor

Dockerize is used for waiting for other services. So I think we can stop to use dockerize and use HEALTHCHECK instead of it.

https://github.com/weseek/growi-docker-compose/blob/68adada4a999e5e3214de013fba6c3b78f75e169/docker-compose.yml#L29..L32

onokatio avatar Feb 15 '23 05:02 onokatio

@inductor Sorry, a conflict occurred by merging https://github.com/weseek/growi-docker-compose/pull/65. Could you resolve it?

yuki-takei avatar Mar 14 '23 05:03 yuki-takei

@onokatio Thank you for your contribution. Would you send us another PR?

yuki-takei avatar Mar 14 '23 05:03 yuki-takei

Taken over at https://github.com/weseek/growi-docker-compose/pull/72

yuki-takei avatar Mar 28 '24 10:03 yuki-takei