cobalt2-vscode icon indicating copy to clipboard operation
cobalt2-vscode copied to clipboard

Inconsitant colors

Open mlonn opened this issue 4 years ago • 8 comments

When viewing a ts file in the side by side view from the source control panel the left side has the colors pre 2.2, and the right side has the colors of 2.2 image

Also primitive types such as string and number does not have the same color as custom types

image

image

The colors are also different when hovering image

mlonn avatar Nov 30 '20 09:11 mlonn

I've opened an issue for the primitive types here: https://github.com/microsoft/vscode/issues/111511

Will have a look at the source control issue in a bit! thanks for reporting

wesbos avatar Nov 30 '20 14:11 wesbos

No worries! Got super confused when I got to work this morning and did not recognize my code. Very nice with more colors in TS, was a bit envious of how it looked in your courses in JS. ;)

mlonn avatar Nov 30 '20 14:11 mlonn

Thanks! Let me know if anything else pops up or doesn't make sense as you use it in TS.

wesbos avatar Nov 30 '20 14:11 wesbos

It's not only happening in source control tab. I'm seeing these differences in all files. Typescript definitions are now also italic/recursive. Is this intended? Especially the React.FC part looks weird.

image

Exactly as reported by @mlonn , correct colors and font style is shown when hovering:

image

Edit: Oh right I guess these are indeed intended changes. The hovering styles are however different.

AriPerkkio avatar Dec 01 '20 06:12 AriPerkkio

Also noticed the same thing this morning. When using TS it really makes the types difficult to read. I also noticed that for object paths the colour is inconsistent (see below).

image

declanelcocks avatar Dec 01 '20 06:12 declanelcocks

Also noticed the same thing this morning. When using TS it really makes the types difficult to read. I also noticed that for object paths the colour is inconsistent (see below).

image

Can you open a new issue for this

KevinDenys avatar Dec 01 '20 09:12 KevinDenys

Function argument color is not equal with the color of the variable within the function image

at least not always

image

If it's on purpose, you can forget my comment

Andy-QT avatar Dec 03 '20 15:12 Andy-QT

https://github.com/microsoft/vscode/issues/111511 Looks like the primitive types is on purpose.

They said to talk to Typescript. Not sure where to open that issue, so I'm going to leave it for now. Not a huge problem for me.

will investigate these other things though :) Thanks for reporting them

wesbos avatar Dec 04 '20 14:12 wesbos