JavaScript30 icon indicating copy to clipboard operation
JavaScript30 copied to clipboard

Make changes to `audio` and `div` to make script compatible with `event.code`

Open sarah-vo opened this issue 2 years ago • 1 comments

event.keyCode is deprecated and may be incompatible in future browser updates. Additionally, I've found that using event.keyCode sometimes prevent sound from being played properly when pressed repeatedly (using macOS 12, Firefox 101), where the sound would not play if you repeatedly press the keystroke. event.code does not have such problem

sarah-vo avatar Jun 23 '22 16:06 sarah-vo

In my opinion this should be implemented since the change is minimal and the user will be warned to use a different method above <script>, since the keystroke id capture used in the video has been deprecated. Using this method in the future would not guarantee that the script would run properly.

sarah-vo avatar Jun 25 '22 06:06 sarah-vo

Duplicate of #466

palashmon avatar Jan 19 '23 12:01 palashmon