privatelock icon indicating copy to clipboard operation
privatelock copied to clipboard

Add option to replace threshold slider with numeric input

Open zoktiik opened this issue 5 years ago • 3 comments

The arbitrary threshold slider is a step back from PluckLockEx. There is no way to accurately fine-tune the threshold to suit your needs; you just have to find your sweet spot through unnecessarily more trial-and-error. The slider might have use for some people, but it can't really work well for all users. Make it an obvious option to replace the slider with an exact numeric input, or even make the toggle be triggered by a button on either side of the slider.

zoktiik avatar Sep 07 '19 18:09 zoktiik

Are you talking about the ability to use decimals as well as integers? e.g. 10.1, 10.2 etc. In my experience testing it on a few devices, moving up a whole integer doesn't make much difference but sensitivity does seem to vary phone-by-phone despite it being the same calculations (the reason I used an arbitrary numeric scale rather than '10ft/s' or something). A slider makes it easy to set without having to click something and type it in (or other input like a popup list), but I can see how it might not be to everyone's taste, and might be a bit fiddly sometimes. But then, how often is it going to be changed realistically? But thanks for your suggestions, I'll keep them in mind.

wesaphzt avatar Sep 07 '19 19:09 wesaphzt

But then, how often is it going to be changed realistically?

Is pretty much my point. In all of the time I've used PLx, I have kept the same exact threshold as I did months ago. And it took no time to figure out what threshold worked out for me. Why? The description accompanying the threshold was accurate and to the point:

A value, in meters per second squared, that the sum of all non-gravitational forces on the phone must exceed for it to lock.

At that point, I know exactly what I'm looking to achieve. My sensitivity of my phone's sensors don't matter; what matters is knowing what my phone will take as a sign to lock. This ability to accurately fine-tune is important to an application used in security, as having the threshold not trigger to one attacker can be a Bad Thing.

zoktiik avatar Sep 07 '19 19:09 zoktiik

Fair points.

wesaphzt avatar Sep 08 '19 19:09 wesaphzt