ZRTP4J icon indicating copy to clipboard operation
ZRTP4J copied to clipboard

Use stock BouncyCastle, remove embedded libs, convert to Maven

Open ibauersachs opened this issue 8 years ago • 3 comments

Closes #4, closes #5

I can try to create multiple smaller pull requests if necessary, but that will be difficult.

Modifications:

  • BigIntegerCrypto removed: incompatible with BouncyCastle
  • Embedded BouncyCastle removed: code duplication just for BigIntCrypto
  • Embedded Curve25519 removed: in BouncyCastle
  • Mavenization: can create an OSGi bundle automatically, doesn't need embedded jars
  • Eclipse files removed: can be created from Maven
  • Fortuna: embedded from bccontrib to avoid dependency. Uses a wrapper now and allows setting a different random source externally
  • License: all GPL-3+ with classpath exception now

ibauersachs avatar Jan 15 '17 23:01 ibauersachs

Hi @ibauersachs,

Haven't read your patch bomb :) Are you periodically reseeding Fortuna periodically?

champtar avatar Jan 16 '17 05:01 champtar

@champtar No, but it's now possible to externally set a different SecureRandom implementation (before the new ZrtpSecureRandom is first accessed).

ibauersachs avatar Jan 16 '17 23:01 ibauersachs

@champtar Oh, and patch bomb: yes, but if you skip all the deleted files it actually isn't much.

ibauersachs avatar Jan 16 '17 23:01 ibauersachs