Jakob Schlanstedt
Jakob Schlanstedt
@contributor Thanks for the additional review. And Improvement Your changes make sense. Let's wait for feedback from Elian. I will cherrypick your changes if he gives me the okay here....
Okay, I will revert to draft. The following things I will fix before reopening for further review: - [x] @contributor Cherrypicking your changes already. To reduce review workload by removing...
@contributor The Commit https://github.com/contributor/trilium/commit/80afdaf8ba835b3639c721309e3f158e1949d13e didn't work yet. In my case it generated the following error: Error Message { "message": "unexpected-error\nRead more: https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-unexpected-error\nOriginal error: ReferenceError: CreateNoteAction is not defined", "stack": "ReferenceError:...
@contributor my bad now I missed giving you the information to work with lol: create note under inbox? Maybe the fault is either in the cherrypicking or somewhere else
@contributor Actually sorry for my fast generalization: funnily I only tested what you didn't test. Thus miscommunication lol. not working: (tested on your branch): using @ to create a note....
@contributor Trace & Log Stack Trace 200 GET /api/notes/RGCyxYx1gtqE/blob with 348 bytes took 0ms JS Error: Uncaught error: Message: Uncaught CKEditorError: unexpected-error Read more: https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-unexpected-error Original error: ReferenceError: CreateNoteAction is...
@contributor Everything else works as expected.
@contributor Code worked perfectly this time! I will now make some tests here and there trying to break this feature in use. If it doesn't break, I will make it...
@contributor I squashed Commits because else it didn't rebase, destroying git history if I merged instead. I mentioned you in the git log instead. The code before the squash can...
@eliandoran Ready for Review: Here a summary of what is important: - Check if it was okay to edit these files: https://github.com/TriliumNext/Trilium/pull/7287#issuecomment-3395231584 - Pls take special attention to this question...