Damian Hryniewicz
Damian Hryniewicz
We have pdfs (possibly multi-paged) that we need thumbnails for. In our case, each page gets converted into an image. Something like with Google Drive - they don't display a...
Yeah, I agree. Take all the time you need and just let me know in a bulk what I can improve.
Ok @dotemacs, I think I resolved all your comments. Let me know if you still would like some fine-tuning.
Now I see that it's somewhat a duplicate of [this issue on weavejester/meta-merge](https://github.com/weavejester/meta-merge/issues/11)
I just realized that that `nil` can be _forced_ by using a `replace` meta key: ```clojure (duct.core/merge-configs {:duct.database.sql/hikaricp {:logger (duct.core.merge/replace nil) :something-else :yay}} {:duct.database.sql/hikaricp ^:demote {:jdbc-url "123" :logger "999"}}) =>...
Hmm... An update to what I said about the workaround using `#duct/replace`: I don't have time to debug now but sometimes the `hikaricp` `logger` overwrite doesn't work despite the replace....
```clojure (duct/prep-config {:duct.profile/base {:duct.database.sql/hikaricp {:logger (duct.core.merge/replace nil)}} :duct.module/sql {:database-url "123"}} profiles) => {:duct.database.sql/hikaricp {:jdbc-url "123", :logger #integrant.core.Ref{:key :duct/logger}}, :duct.migrator/ragtime {:database #integrant.core.Ref{:key :duct.database/sql}, :strategy :raise-error, :logger #integrant.core.Ref{:key :duct/logger}, :migrations []}} ```
I think I too would rather use the non-meta data structure for modules. I'm neither familiar with Java's annotations nor Python's decorators so I can't relate to that point you...