Raman Fedaseyeu

Results 52 comments of Raman Fedaseyeu

Thank you for doing the additional tests. I'll reopen this ticket, but it would help if you add this detail about the delay into the original post. This seems to...

Please, check the documentation on [Stream.listen(⋯)](https://api.flutter.dev/flutter/dart-async/Stream/listen.html). You cannot use try-catch around a call to `Stream.listen(⋯)` to catch errors in a stream, because the call completes before events start to come...

> Some comments regarding [944e2a9](https://github.com/PhilipsHue/flutter_reactive_ble/commit/944e2a9cae75e937431dc843693033462694d53f). I suppose it's fine to include those changes in this pull request, but please go through all the comments already left by me. Aside from...

Reminding of my [earlier question](https://github.com/PhilipsHue/flutter_reactive_ble/pull/453#discussion_r754406740): > @ened Do descriptors _always_ have 16-bit IDs and cannot have longer or shorter IDs? `CBDescriptor.id` has type `CBUUID` and that thing can contain IDs...

> At the moment, the code defines `DescriptorAddress` like this: > > ``` > message DescriptorAddress { > string deviceId = 1; > Uuid serviceUuid = 2; > Uuid characteristicUuid...

Looks good to me. Thank you for the pull request. I assume you've tested the change sufficiently, can you confirm, @atbamparo?

@sjoerd0301 Thank you for the update. Do you believe you tested your changes sufficiently? If yes, this looks good to me. CC @Taym95 @remonh87

It seems `CBCentralManagerDelegate` does not explicitly return discovery errors, which means we'd need an explicit rule "if BLE status changes to 'off' while in discovery, throw an exception". We don't...

> I know from Android that parallel BLE operations are a bad practice and can yield into weird behavior. I'd rather call them "concurrent", not parallel. True for Android. >...