valet-plus icon indicating copy to clipboard operation
valet-plus copied to clipboard

Use SHA265 for generating self signed certificates

Open stormbyte opened this issue 4 years ago • 9 comments

  • [x] There is an issue ticket which accompanies my PR: https://github.com/weprovide/valet-plus/issues/520
  • [x] I have followed the guidelines for contributing.
  • [x] I have checked that there aren't other open pull requests for the same issue ticket.
  • [x] I have formatted my code with the PSR-2 coding style before submitting my PR.

I have read the contribution guidelines and am targeting the branch 2.x:
Because this is a Bug Fix which is Backwards Compatible. Should be backwards compatible as it is an additional option to openssl. Rest of the code should not be affected Changed to 2.x branch because build does not work for PHP5.6

Changelog entry:
Add to the openssl command that it should use the sha265 encryption

stormbyte avatar Sep 01 '20 11:09 stormbyte

Test fail because test php 5.6 environment with php 7.x code ??

stormbyte avatar Sep 01 '20 11:09 stormbyte

/AzurePipelines run

Neodork avatar Sep 21 '20 18:09 Neodork

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 21 '20 18:09 azure-pipelines[bot]

/AzurePipelines run

Neodork avatar Sep 21 '20 19:09 Neodork

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 21 '20 19:09 azure-pipelines[bot]

/AzurePipelines run

Neodork avatar Sep 22 '20 14:09 Neodork

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 22 '20 14:09 azure-pipelines[bot]

/AzurePipelines run

stormbyte avatar Dec 14 '20 08:12 stormbyte

Commenter does not have sufficient privileges for PR 522 in repo weprovide/valet-plus

azure-pipelines[bot] avatar Dec 14 '20 08:12 azure-pipelines[bot]

This works for me 👍

SanderAtom avatar Nov 07 '22 15:11 SanderAtom

Also merged to release/2.4 branch.

mischabraam avatar Nov 17 '22 10:11 mischabraam