valet-plus icon indicating copy to clipboard operation
valet-plus copied to clipboard

Bug: Chrome dropped SHA1 support

Open stormbyte opened this issue 4 years ago • 2 comments

  • [x] I've checked the issue queue and could not find anything similar to my bug.
  • [x] I'm on the latest version of valet-plus (valet --version): Valet+ 2.0.0
  • [x] I've run valet fix and valet install after updating and before submitting my issue/feature.

What is the problem? After 11 years chrome has really dropped support for SHA1 certifacates.

What was supposed to happen? The secure sites should be secure

What actually happened? The secure sites are no longer secure.

How to reproduce this? run the valet secure command and open chrome browser.

What is the solution? Use SHA265

Sources https://www.chromium.org/Home/chromium-security/education/tls/sha-1

stormbyte avatar Sep 01 '20 09:09 stormbyte

@stormbyte Thanks for your PR! Edit: Ignore my previous comment I was confused with another ticket. Can you still answer my BC compatible question? If you do I can probably merge this right away and it'll be in next release.

Neodork avatar Sep 21 '20 18:09 Neodork

@Neodork I might be missing the question as I don't see the previous comment. Openssl should support sha256 https://www.openssl.org/docs/man1.0.2/man3/SHA256.html

stormbyte avatar Nov 22 '20 15:11 stormbyte