valet-plus icon indicating copy to clipboard operation
valet-plus copied to clipboard

Install: Package container-interop/container-interop is abandoned

Open GeoJunkie opened this issue 6 years ago • 4 comments

On a clean installation, during the composer global require weprovide/valet-plus, I get the following warning:

Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead.

I checked the usage and found this is related to the mnapoli/silly package:

➜  ~ composer global  why container-interop/container-interop
Changed current directory to /Users/***/.composer
mnapoli/silly   1.5.1  requires  container-interop/container-interop (~1.0)
php-di/invoker  1.3.3  requires  container-interop/container-interop (~1.1)

mnapoli/silly moved to psr/container in Version 1.6.0. Should Valet+ move to the newest version?

GeoJunkie avatar Dec 02 '19 11:12 GeoJunkie

@GeoJunkie Good catch. We'll have to upgrade mnapoli/silly but check if the package has made non-BC changes. Since that's the core valet+ is running on. We could also have a check with laravel/valet to see what they did.

Neodork avatar Dec 06 '19 11:12 Neodork

@majstomphorst This is a warning, not an error.

I'd open your own issue, and paste the full output somewhere for someone to read to be able to find out what your issue is, or do the same in the slack.

Mezzle avatar Dec 09 '19 09:12 Mezzle

@Neodork I actually posted this over on laravel/valet because with my limited understanding of composer.json I didn't catch the differences between the two files.

valet plus: "mnapoli/silly": "~1.5.0", laravel/valet: "mnapoli/silly": "~1.0",

As they pointed out in my misguided issue there, their parameter "means it'll use anything 1.x.x ... which right now means it's using the latest version."

So if the valet-plus composer.json was updated to replace ~1.5.0 with ~1.0 that SHOULD fix everything, right?

GeoJunkie avatar Dec 10 '19 12:12 GeoJunkie

I got this error also, is it safe to simply ignore it, or what should I do about this?

BrunoAHVincent avatar Feb 02 '20 01:02 BrunoAHVincent