whois-parser icon indicating copy to clipboard operation
whois-parser copied to clipboard

Add ostruct to gemspec for Ruby 3.5

Open halilim opened this issue 1 year ago • 3 comments

Fixes the warning:

.../lib/whois/parser/super_struct.rb:1: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.

halilim avatar Jan 03 '25 04:01 halilim

Thanks for this @halilim, for the record this project isn't really maintained by @weppos any more, so I ended up starting my fork in which I fixed most of the issues. I try to keep it maintained in hope it could be merged back upstream some day so everyone can benefit from it. I just cherry-picked your PR here https://github.com/jarthod/whois-parser/commit/66c5b0303272138ea7b38f426dabc3a8b391ba3f and updated the test suite here: https://github.com/jarthod/whois-parser/actions/runs/12810390972 (it's now passing even on ruby-head). So if you need this (and the many other fixes) you can use my fork in the meantime:

gem 'whois-parser', github: 'jarthod/whois-parser' # Unofficial but more up-to-date fork, check status at https://github.com/jarthod/whois-parser

jarthod avatar Jan 16 '25 13:01 jarthod

Thank you, @jarthod! Interesting. @weppos seems active, but not in this repo. It looks like we'll have to adopt a fork.

halilim avatar Jan 19 '25 11:01 halilim

Yes I'm only talking about this project :)

jarthod avatar Jan 19 '25 16:01 jarthod