Simone Carletti comments

Results 60 comments of


                                            Simone Carletti

Allow default rule to be override

> I had a look at the algorithm page but its not clear what is the expected behaviour of *. I was really confused by this behaviour change in 2.0....

Allow default rule to be override

@pjg the main problem is that you expect this library to be a validation tool, whereas it's not (the PSL is not designed to validate). I think it's simply a...

Handle OAuth errors properly

That's correct. In the `Go` client I already patched it as we spotted this issue while working on one of the addons. https://github.com/aetrion/dnsimple-go/commit/ce4241ee6b4fbbe9e3b106527c8e5a19d783e2e4 So far, all the clients have two...

reset_session after logging in wipes out non-sorcery info from session such as csrf_token

+1 same issue here

Expose specific model errors on validation error

Sorry about that @randallmlough. We'll see if we can prioritize the work. Feel free to provide a PR if you have something ready.

Expose specific model errors on validation error

Related to https://github.com/dnsimple/dnsimple-developer/issues/133

Fix domain_id, registrar and contact parsing for afilias

Thanks for all the patches @cork. I'll schedule some time this week to review and merge them.

`Whois::ParserError: Unexpected token` on AU domains parsing

There repo is not abandoned. GDPR changed pretty much each and every single registrar response, and I just don't have the time to follow up on all these changes. I...

Fix corporatedomains whois date format with slashes

@njng can you explain how you generated the fixture with the dates with slashes? I performed a live whois query, but what I see is: ``` Domain Name: corporatedomains.com Registry...

Import fails with error "nil entry in ImportState results"

Can you confirm as to whether the record you were trying to import did exist? ``` 2020-07-24T17:08:38.409-0500 [DEBUG] plugin.terraform-provider-dnsimple_v0.4.0_x4: 2020/07/24 17:08:38 DNSimple Record Not Found - Refreshing from State ```