bootstrap-table icon indicating copy to clipboard operation
bootstrap-table copied to clipboard

Show/hide/toggle multiple rows

Open 9r0x opened this issue 3 years ago • 5 comments

🤔Type of Request

  • [ ] Bug fix
  • [x] New feature
  • [x] Improvement
  • [x] Documentation
  • [ ] Other

🔗Resolves an issue?

Fix #5711

📝Changelog

  • Added APIs for show/hide/toggle multiple rows at a time
  • [x] Core
  • [ ] Extensions

💡Example(s)?

https://live.bootstrap-table.com/code/9r0x/12229

☑️Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • [x] Doc is updated/provided or not needed
  • [x] Demo is updated/provided or not needed
  • [x] Changelog is provided or not needed

9r0x avatar Jul 22 '22 00:07 9r0x

Hi, is there a general guideline for updating changelog and examples?

Also, since this at the moment slightly breaks the previous API, please let me know if there's a better way to incorporate the features.

9r0x avatar Jul 22 '22 00:07 9r0x

For the changelog just describe what this PR does (Adds a new methods [...]). We should avoid the BC, you could keep the old functions which calls the new functions internaly with one row (or did i miss something?) Also please provide us an example using our editor (as described in the issue template).

UtechtDustin avatar Jul 22 '22 07:07 UtechtDustin

There are 3 ways I could think of

  1. Keep the same singular(e.g. hideRow) form, but internally allows an array of rows as input; simple but less intuitive because all parameters(row, index, uniqueID) are singular.
  2. Add additional plural form(e.g. hideRows), which makes it a bit confusing with 6(vs 2 before) functions representing similar features
  3. Replace singular form with plural form, simplest and most intuitive, but breaks API.

I would proceed with 2 but hide the singular form from the doc, so the doc would be less confusing while still internally supports historical versions

9r0x avatar Jul 23 '22 02:07 9r0x

It seems the Online editor keeps using an old version of my code before my last force-push, is there a way to refresh the cache or whatever that causes the editor to use an old version of the library?

I by accident added an unused require statement in the previous push, and immediately force-pushed with the fix, then the editor still reports the missing library. Screen Shot 2022-07-24 at 13 38 08

9r0x avatar Jul 24 '22 20:07 9r0x

Change log:

  • Added APIs for show/hide/toggle multiple rows at a time

Example: https://live.bootstrap-table.com/code/9r0x/12229

9r0x avatar Jul 28 '22 02:07 9r0x

Lets us know if you are still intrested to help with this PR, we will reopen the PR then.

UtechtDustin avatar Feb 11 '23 20:02 UtechtDustin