bootstrap-table icon indicating copy to clipboard operation
bootstrap-table copied to clipboard

Size of Filter Control

Open g3rd0 opened this issue 4 years ago • 9 comments

Description
For the toolbar, search fields, pagination, etc. the values from data-icon-size are taken over. However, the filter control fields may have a different size.

https://live.bootstrap-table.com/code/sebastiangehrt/6450

Here, should btn-XX also be added for a consistent look.

g3rd0 avatar Jan 30 '21 12:01 g3rd0

Example with fix: https://live.bootstrap-table.com/code/djhvscf/9693

djhvscf avatar Nov 23 '21 03:11 djhvscf

@djhvscf The class form-control is missing for the select, which cause in a other style of the inputs.

UtechtDustin avatar Nov 23 '21 08:11 UtechtDustin

The form-control class is there:

image

djhvscf avatar Nov 25 '21 04:11 djhvscf

The form-control class is there:

image

The form-control class (without -sm) of the select :-) Bildschirmfoto 2021-11-25 um 09 11 34

UtechtDustin avatar Nov 25 '21 08:11 UtechtDustin

If I add the form-control class then the form-control-sm is not applied. I don't think we need form-control class when using form-control-{size}

djhvscf avatar Nov 25 '21 14:11 djhvscf

For me it works fine, it is also needed. Please check the bootstrap 4 documentation. Bildschirmfoto von 2021-11-25 18-50-45

UtechtDustin avatar Nov 25 '21 17:11 UtechtDustin

ok, let me review it

djhvscf avatar Nov 25 '21 20:11 djhvscf

I think I'm going to remove this issue from the scope of https://github.com/wenzhixin/bootstrap-table/pull/5583 since the filter control extension does not work in other themes. @UtechtDustin @wenzhixin

djhvscf avatar Nov 28 '21 00:11 djhvscf

See this issue for tracking purposes https://github.com/wenzhixin/bootstrap-table/issues/5968

djhvscf avatar Nov 28 '21 00:11 djhvscf