bootstrap-show-password icon indicating copy to clipboard operation
bootstrap-show-password copied to clipboard

Option to *not* wrap in input-group

Open jpalmieri opened this issue 5 years ago • 3 comments

Addresses #25

• Adds an option to not wrap the elements in an input-group • In this case, it will also append the icon to the parent (rather than inserting it after the text field). This addressed the use case of having an input-group with additional elements (other than the password field, text field, and icon from this library).

If this is acceptable, I can add documentation.

jpalmieri avatar Jun 21 '19 23:06 jpalmieri

Thanks for your contribution! It's a useful option, please help to update the documentation. BTW, we don't need to build the dist, when we release a new version, we will do that.

wenzhixin avatar Jun 23 '19 10:06 wenzhixin

@wenzhixin could this get merged? Thank you!

ellisonpatterson avatar Mar 19 '20 16:03 ellisonpatterson

Sorry for dropping the ball on this. The branch still needs to add the new option to documentation and remove the dist build, as well as address the conflicts. Feel free to take that on @ellisonpatterson

jpalmieri avatar Mar 19 '20 18:03 jpalmieri

closing this because I don't want to make it merge-ready, and I have to delete my local repo. I also have no idea how relevant this is anymore

jpalmieri avatar May 07 '24 19:05 jpalmieri