Wenyong Huang

Results 323 comments of Wenyong Huang
trafficstars

> > > > Yes, patching llvm seems a good way instead of changing the AOT file format, @dongsheng28849455 could we apply the patch to llvm before we build llvm...

@haruki3hhh thanks for spotting the issue, it was fixed with #3126.

Close the issue since it had been fixed.

Hi, could you try enlarging the `Max linear memory size`, and adding malloc and free in the `Exported symbols`?

@eloparco I have a try, the `aot_memmove` and `aot_memset` are called from the AOT code when bulk memory feature is enabled, in which the wasm opcode `memory.copy` and `memory.fill` are...

Yes, we had better acquire the lock only for the native functions that use linear memory, but it is not easy to know whether a wasi function uses linear memory...

> Completely agree, I don't think there's an automatic way to find all the WASI functions that access linear memory (the call of `validate_native_addr` gives us a hint, but what...

> @wenyongh just one more thought on that; users can expose custom native functions to WASM; don't you think we should in that case expose a public API for them...

> > I didn't add lock for the wasi function > > do you mean wasi functions that access linear memory? Yes.

@loganek Yes, sounds good to let user add or remove lock by himself, and we can provide the API to acquire and release lock. For the TSAN, I have no...