William Wen
William Wen
Instead of exposing as `multipart upload`, I will prefer to expose it as `streaming_upload` with `write_bytes` and `finish` method. The multipart upload implementation detail will be hidden inside the streaming...
> I think we should distinguish the multipart upload in ObjectStore's interface from S3's multipart upload. In our code, multipart upload simply means that "you can upload an object part...
I am willing to make such refactor if needed.
Seems that there is few issue related to recovery happening now. We may close the issue now.
> I am a bit concerned with a 2.3K LoC PR with zero test :( > > Is it possible to split it into smaller PRs and add some tests...
Left a comment in the previous PR. Might be fixed by the way in this PR. https://github.com/risingwavelabs/risingwave/pull/15371#discussion_r1512182710
> Can you add some comments on the motivation behind this PR? The main motivation behind this PR is for support of partial checkpoint. In the design of partial checkpoint,...
@hzxa21 @BugenZhao @kwannoel @yezizp2012 @shanicky The PR is ready for review now. PTAL~
> > `InjectBarrierResponse` and `BarrierCompleteRequest` is no longer needed and is removed in this PR. > > Prior to this PR, we have await-tree instrumentation for all RPC calls. The...
> > > > `InjectBarrierResponse` and `BarrierCompleteRequest` is no longer needed and is removed in this PR. > > > > > > > > > Prior to this PR,...