wenyan icon indicating copy to clipboard operation
wenyan copied to clipboard

chore: use the sensible build... compatibly

Open Artoria2e5 opened this issue 4 years ago • 3 comments

We try to use the "sensible" build when possible, handling all the old try/catch magic in catsrc. This mostly works, except for a problem in the parser that appears to be also present in a previous version: a huge object tries to reference things that don't exist.

[The site is unchanged for now to avoid breaking any new things. Somebody added a // comment to CSS which is invalid, so expect it to not work. I did not break it.]

The eslint rules are enabled. They don't really hit any package problems any more, so I figure it's time to turn them on. I added an rc for the tests so every complaint left is a true positive now. FIxing them? not my job.

The Makefile has been rewritten to be aware of new changes. In the long run webpack would be the way to go still.

Artoria2e5 avatar Dec 28 '19 10:12 Artoria2e5

And who came up with the idea of committing built stuff to master anyways?

Artoria2e5 avatar Dec 28 '19 10:12 Artoria2e5

Hi @Artoria2e5 Please make sure all the tests pass. Thanks!

antfu avatar Dec 30 '19 12:12 antfu

The failures are mainly due to new eslint rules being enabled. Confirm that you want these things fixed. (No false positives, so I guess it should be a go.)

Artoria2e5 avatar Dec 30 '19 18:12 Artoria2e5