Mateusz "Serafin" Gajewski

Results 378 comments of Mateusz "Serafin" Gajewski

This branch is not rebased: ``` commit e1dc146f2409447318c47a0ebf1167fa4c315942 Author: Martin Traverso Date: Mon Sep 25 09:21:59 2023 -0700 Avoid exponential DFA in LIKE matcher When a pattern contains a %...

After rebasing I'm getting the same compilation errors as in the CI: ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.12.1:compile (default-compile) on project trino-elasticsearch: Compilation failure: Compilation failure: [ERROR] /Users/mateuszgajewski/Projects/src/github.com/trinodb/trino/plugin/trino-elasticsearch/src/main/java/io/trino/plugin/elasticsearch/ElasticsearchQueryBuilder.java:[37,57] package...

I've rebased this PR locally and checked the dependency scope failure and here's the fix: ``` commit d896b0cf12d7b4c16818467166f225dbe38546fc Author: Mateusz "Serafin" Gajewski Date: Sun Feb 4 11:19:06 2024 +0100 Fix...

@xxzhky failure is in the dependency scope check, not tests. Tests are passing just fine on the CI.

@hboutemy I agree. I happen to know that the build is not username/hostname/current directory sensitive, because I've tested that manually but I don't know how to test that in the...

@martint around ~12~ 17 minutes

@martint we can run this only on master if we want to save some time.

@hboutemy thanks for letting me know. I'll try to fix the rpm to be independent of the hostname

@hboutemy this will fix the rpm: https://github.com/trinodb/trino/pull/22135

@hboutemy 449 is out. Can you try it?