Lawrence Mitchell

Results 363 comments of Lawrence Mitchell

@lithomas1 are you going to try and get this in for 24.08?

Ah, I realise I had the same high-level issue as @vyasr, it seems like you'd decided to do that separately?

> (but eventually, I would like this to take a pylibcudf Scalar) Why is this one so hard? I think you just need to have a big switch statement in...

> I could also try to delete the datetime/timedelta handling code in this PR. (I don't think that gets used in cuDF Python) This is kind of critical for predicate...

> I think your proposed approach would work after we fixed the Scalar constructor. Yeah, I think from the pylibcudf point of view in some sense, for the expression API,...

Related request: https://github.com/rapidsai/cudf/issues/15118

> Hi, > > I've successfully implemented the feature as described above. However, while running pytest to verify the functionality across the project, I encountered an issue: 'module cudf is...

> Since I'm using a pc without a gpu is this the root of the issue? Yes, you can build cudf without a gpu, but you won't be able to...

This is, I think, a bug in cuco, the left anti join uses `cudf::detail::contains`, which uses a `cuco::static_set` whose implementation type is `cuco::detail::open_addressing_impl`. That object's constructor allocates space for storage,...

> I just wanted to compare my code without any code changes as I thought that cuDF has feature parity with pandas df. Mostly, but not completely. Other than the...