RelightableAvatar icon indicating copy to clipboard operation
RelightableAvatar copied to clipboard

Published 20 hours ago • verified publisher icon wenbin-lin

Questions about the details in render_with_sg

Open zeng798473532 opened this issue 9 months ago • 1 comments

Hi, thanks for your great work. I have some questions about the details in render_with_sg.

Q1: Compare to the codes in PhySG and InvRender, I notice that there is an extra roughness_basis. What can it do and why add this basis?

Q2: Why select the first SG in (Line 704 to 710): https://github.com/wenbin-lin/RelightableAvatar/blob/3254983e4810c4d4b3eba31ce293b3c9a925c0a4/lib/networks/sdf_mat_network.py#L704-L710

zeng798473532 avatar Feb 24 '25 07:02 zeng798473532

  1. We find that directly optimizing the roughness is hard to get good results. The idea of using basis is from this paper.
  2. Thanks for noticing it. It seems like a bug and I will check and fix it soon.

wenbin-lin avatar Feb 28 '25 13:02 wenbin-lin