wemake-python-styleguide
wemake-python-styleguide copied to clipboard
Issue #1891
I have made things!
- Add windows-specific build
- Skip platform-specific tests
Checklist
- [X] I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
- [X] I have created at least one test case for the changes I have made
- [X] I have updated the documentation for the changes I have made
- [X] I have added my changes to the
CHANGELOG.md
@sobolevn Hello, Nikita! I'm not really sure that I properly understand how github actions actully works. Can you review my request and give some feedback?
@AlexandrKhabarov please, take a look at https://github.com/AlexandrKhabarov/wemake-python-styleguide/actions/runs/592660378
Codecov Report
Merging #1899 (a38f140) into master (8f72647) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## master #1899 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 115 116 +1
Lines 6145 6182 +37
Branches 1375 1375
=========================================
+ Hits 6145 6182 +37
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...ke_python_styleguide/visitors/tokenize/comments.py | 100.00% <ø> (ø) |
|
| wemake_python_styleguide/logic/system.py | 100.00% <100.00%> (ø) |
|
| wemake_python_styleguide/constants.py | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 8f72647...a2b8d41. Read the comment docs.
@AlexandrKhabarov can you please help me with fixing the CI? I don't have any experience with windows, it just scares me too much 😨
I will try to solve it soon.
I installed poetry and dependencies of the project, but now flake8 failed.
This is related to https://gitlab.com/pycqa/flake8-docstrings AFAIK, it is not tested on windows, so it might have this problem. Or we can skrew something up on ourside, you never know 🙂
Can you please report this issue to flake8-docstrings team? It looks like a valid issue to me 🤔