Mike Welsh comments

Results 28 comments of


                                            Mike Welsh

Have computed var properties also use the queue to add invocations safely

@maxim-chipeev @AnthonyUccello-Faire

Have computed var properties also use the queue to add invocations safely

@navartis @spaluchiewicz looks like you're the most recent committers? Are you reviewing pull requests for this repo?

Have computed var properties also use the queue to add invocations safely

Anything I can do to help get this reviewed and merged?

Exclude URLs from Tracing

Maybe there's a better place to ask for help, but I'm trying to resolve this problem with the extension workaround. When attempting to run the extension [example here](https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/examples/extension) I get...

[Java][Spring][Issue: 18929] fix missing JsonIgnoreProperties import in oneOf interface file

Can you generate the samples and include as part of this review? ``` ./bin/generate-samples.sh ./bin/configs/*.yaml ```

[Java][Spring][Issue: 18929] fix missing JsonIgnoreProperties import in oneOf interface file

> Hi @welshm , I ran the scripts locally before committing and it lead to no changes within the repository. I assume that was the expected outcome? > > I...

[Java][Spring][Issue: 18929] fix missing JsonIgnoreProperties import in oneOf interface file

Change LGTM - approved from wrong account 🤦

[Java][Spring][Issue: 18929] fix missing JsonIgnoreProperties import in oneOf interface file

I would see if the MODEL_NAME_SUFFIX is being set in the test and if so, does changing it impact the file name and then try to trace it from there....