Weslley Araújo

Results 93 comments of Weslley Araújo

@abbychau, what happens if you put the `const app = new AppController(...)` inside the async wrapper? Can you also test it without the `app` instance? I tried a simple *repro*...

> NodeJS: v20.8.1 (both on my windows system and Debian VPS) MySQL Server: v8.0.27 (VPS), v8.0.32 Windows mysql2: 3.6.2 (Windows & Debian) I'm using Debian 10 on my VPS @slice3984,...

> Edited --- This happens when you change the native `JSON.stringify` method: ```js // It's a string return ((function () { return class TextRow { constructor(fields) { } next(packet, fields,...

Since this error comes from an external dependency, I will close this issue as _not planned_. But feel free to ask anything and reopen it at anytime 🙋🏻‍♂️

Thanks, @sidorares 🙋🏻‍♂️ I've adjusted my comment.

> cc @wellwelwel bump on this @KunZhou-at, thank you for your many contributions 💙 This one in particular I couldn't figure out what the issue was and what the solution...

Thanks, @fenying 🙋🏻‍♂️ Recently (#2472), we refactored all the tests. Now, all test files need to have extensions as `*.test.cjs` (_/test/{unit,integration}/**_) or `*.test.mjs` (_/test/esm/**_).

@fenying, in _test/tsc-build/mysql/createPool/callbacks/createPool.test.ts_, you don't need this 🙋🏻‍♂️ ```diff - pool = mysql.createPool({ - ...access, - acquireTimeout: 1000, - }); ``` --- In _test/integration/test-pool-acquire-timeout.test.js_, you can change the file name...

@fenying, please, ignore the `codecov/patch` for now. I need to set it to **2%** variation (it's currently **0%**).

Hi, @tirengarfio 🙋🏻‍♂️ From **MySQL2** documentation: > MySQL2 is mostly API compatible with Node MySQL. You should check their API documentation to see all available API options. Also: > MySQL2...