vaes icon indicating copy to clipboard operation
vaes copied to clipboard

UnlabelledDataSet: self.images

Open erlebach opened this issue 8 years ago • 2 comments

Hi,

Yet, in train(), you call:

      feed_dict[x], feed_dict[x_w] = training_data.next_batch(batch_size, whitened=False)

(my line numbers no longer correspond to yours). Note that in UnlabelledDataSet, the last few lines are:

    if whitened:
        return self.images[start:end], self._whitened_images[start:end]
    else: return self._images[start:end], self.images[start:end]

whitened is false, and self.images is not defined. Why does this work? Thanks.

erlebach avatar May 29 '17 20:05 erlebach

Sorry about that, this is messy and needs refactoring - it's actually calling the @property self.images, which is actually just defined as self._images

wellecks avatar May 30 '17 13:05 wellecks

Thank you! I have no direct experience with properties. Now I know: property implicitly defines a class variable.

Gordon

On Tue, May 30, 2017 at 9:23 AM, Sean Welleck [email protected] wrote:

Sorry about that, this is messy and needs refactoring - it's actually calling the @property self.images, which is actually just defined as self._images

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wellecks/vaes/issues/10#issuecomment-304876462, or mute the thread https://github.com/notifications/unsubscribe-auth/AAT0ZCc0E12JMyRzmWfxP199TpmG5hl-ks5r_Bg1gaJpZM4Npm1s .

-- Gordon Erlebacher Chair, Department of Scientific Computing

erlebach avatar May 30 '17 13:05 erlebach