why-did-you-render icon indicating copy to clipboard operation
why-did-you-render copied to clipboard

Tracking custom hooks issue

Open c-betton opened this issue 2 years ago • 3 comments

Hello all,

I'm starting using the 'why-did-you-render' library. I would like to track my custom hooks but it seems not working on my side.

Here is my configuration (starting with only one custom hook to simplify) set in the 'wdyr.ts' file content: image

And the custom hook I'm using export const useUploadApk = (): UploadApk => { ... const [callGetUrl, setCallGetUrl] = useState(false) const [callUpload, setCallUpload] = useState(false) ... }

This custom hook is using useState hook and is called from a form. When running the App, I got the following trace: image

I was expecting to see my custom hook name (useUploadApk) in the trace... Do I miss something in trackExtraHooks syntax? Thanks a lot in advance for any help.

c-betton avatar Jan 24 '24 15:01 c-betton

always wrap value into useMemo before passing it into ContextProvider, same with custom hooks return object, or better just inline your custom hook. Believe me, it is bad abstraction.

JustFly1984 avatar Jan 24 '24 15:01 JustFly1984

always wrap value into useMemo before passing it into ContextProvider, same with custom hooks return object, or better just inline your custom hook. Believe me, it is bad abstraction.

Thanks a lot for your answer, Could you please give me an example?

c-betton avatar Jan 24 '24 16:01 c-betton