player icon indicating copy to clipboard operation
player copied to clipboard

Cannot build

Open dvhassel opened this issue 11 years ago • 2 comments

Hello,

I tried to build the latest release of the WellcomePlayer (I've succesfully deployed the 1.0.0 release on a test server), but I'm stuck with some errors:

Using tsc v1.0.1

TypeScript compilation complete: 14.62s for 54 typescript files

Running "replace:dependenciesSimplify" (replace) task

Running "extend:config" (extend) task File "src/extensions/coreplayer-mediaelement-extension/config.js" created. File "src/extensions/coreplayer-pdf-extension/config.js" created. File "src/extensions/coreplayer-seadragon-extension/config.js" created.

Running "less:dev" (less) task Warning: Cannot read property 'contents' of undefined Use --force to continue.

Aborted due to warnings.

Could someone give me a hand on this?

Thanks

dvhassel avatar Dec 11 '14 19:12 dvhassel

Hi,

It looks like it might be a problem with the theme submodule. Did you do a:

git submodule init git submodule update

(in the player directory)?

I tried cloning a fresh copy of the player and compiled it without initialising the submodules and got an error at the same stage of compilation:

Using tsc v1.0.1



TypeScript compilation complete: 16.17s for 54 typescript files

Running "replace:dependenciesSimplify" (replace) task

Running "extend:config" (extend) task
File "src/extensions/coreplayer-mediaelement-extension/config.js" created.
File "src/extensions/coreplayer-pdf-extension/config.js" created.
File "src/extensions/coreplayer-seadragon-extension/config.js" created.

Running "less:dev" (less) task
>> FileError: '../../../themes/coreplayer-default-theme/theme.less' wasn't found in   src/extensions/coreplayer-mediaelement-extension/css/styles.less on line 10, column 1:
>> 9 
>> 10 @import '@{theme-path}theme.less';
>> 11 @theme:"coreplayer-default-theme";
Warning: Error compiling src/extensions/coreplayer-mediaelement-extension/css/styles.less Use --force to continue.

Aborted due to warnings.
Process finished with exit code 6

I then initialised the submodules and it built successfully.

edsilv avatar Dec 11 '14 20:12 edsilv

Hello Edward,

I tried again, with a new clone and it works now. I must have cloned the wrong branch somehow.

Thanks! Dieter

On Thu, Dec 11, 2014 at 9:39 PM, Edward Silverton [email protected] wrote:

Hi,

It looks like it might be a problem with the theme submodule. Did you do a:

git submodule init git submodule update

(in the player directory)?

I tried cloning a fresh copy of the player and compiled it without initialising the submodules and got an error at the same stage of compilation:

Using tsc v1.0.1

TypeScript compilation complete: 16.17s for 54 typescript files

Running "replace:dependenciesSimplify" (replace) task

Running "extend:config" (extend) task File "src/extensions/coreplayer-mediaelement-extension/config.js" created. File "src/extensions/coreplayer-pdf-extension/config.js" created. File "src/extensions/coreplayer-seadragon-extension/config.js" created.

Running "less:dev" (less) task

FileError: '../../../themes/coreplayer-default-theme/theme.less' wasn't found in src/extensions/coreplayer-mediaelement-extension/css/styles.less on line 10, column 1: 9 10 @import '@{theme-path}theme.less'; 11 @theme:"coreplayer-default-theme"; Warning: Error compiling src/extensions/coreplayer-mediaelement-extension/css/styles.less Use --force to continue.

Aborted due to warnings. Process finished with exit code 6

I then initialised the submodules and it built successfully.

— Reply to this email directly or view it on GitHub https://github.com/wellcomelibrary/player/issues/1#issuecomment-66684792 .

dvhassel avatar Dec 11 '14 20:12 dvhassel