wellcomecollection.org icon indicating copy to clipboard operation
wellcomecollection.org copied to clipboard

Do we need the separate Image and Picture types?

Open alexwlchan opened this issue 2 years ago • 3 comments

An Image supports multiple crops; a Picture only has a single size. It's not immediately obvious to me why we have both, and whether we need two distinct types.

We should investigate, and either:

  1. Discover we don't need two, and get rid of one (probably collapse uses of Picture into Image)
  2. Discover we do need two, and document the reason

alexwlchan avatar Aug 25 '22 11:08 alexwlchan

Could do with more context on this one! Is this a Prismic thing?

LaurenFBaily avatar Apr 25 '24 10:04 LaurenFBaily

This ticket was created because we have different React components to render an image, these are only a few as I'm sure there are more:

So it doesn't have to do with Prismic, really, but with how we treat image rendering. What we'd like to use this ticket for is to understand why we use those different methods and possibly establish when each should be used.

rcantin-w avatar Apr 25 '24 10:04 rcantin-w

This ticket was mentioned during our a11y training as we were told that <picture> didn't have a useful role. I'll add the a11y label so it's on the same radar.

rcantin-w avatar Sep 25 '24 15:09 rcantin-w