platform icon indicating copy to clipboard operation
platform copied to clipboard

Reconsider the fieldset defined in the MinimalRelatedWorkFields type.

Open paul-butcher opened this issue 3 years ago • 0 comments

When working on https://github.com/wellcomecollection/platform/issues/5415, I noticed that the set of properties defined in MinimalRelatedWorkFields (https://github.com/wellcomecollection/wellcomecollection.org/blob/main/common/model/catalogue.ts) may not actually be minimal.

Part of the inspiration for this ticket is that, as part of https://github.com/wellcomecollection/platform/issues/5408, we will be introducing related objects (not strictly Works) which have no id.

However, I also notice that in every test, alternativeTitles is set to [] (which is common in the real data), and availabilities is often set to [] (though this seems to be populated in all records I looked at in Real Life).

referenceNumber also only seems relevant to Archive works, in at least one Manuscript (t6ummfzd), it's a copy of the title, presumably to get around the requirement that it must be present.

paul-butcher avatar Feb 15 '22 16:02 paul-butcher