large-records icon indicating copy to clipboard operation
large-records copied to clipboard

Support ghc 9.6

Open TristanCacqueray opened this issue 1 year ago • 1 comments

TristanCacqueray avatar Aug 06 '23 17:08 TristanCacqueray

Well, I haven't tried the change, this simply fix the compilation errors. This depends on: https://github.com/ndmitchell/record-dot-preprocessor/pull/59

TristanCacqueray avatar Aug 06 '23 17:08 TristanCacqueray

@edsko would it be possible to get this merged? large-generics (and dependants) is broken for 9.6+ on nixpkgs and applying this PR over there doesn't work because the merge of #152 gave it conflicts

alexfmpe avatar May 26 '24 21:05 alexfmpe

I appreciate the work that @TristanCacqueray did, but it only got us part of the way there. But hopefully I should have an updated PR soon, and then I will make Hackage releases.

edsko avatar May 29 '24 08:05 edsko

You are welcome. Well, after fixing this build, I realized large-records was added transitively by proto3-suite through an optional flags, and it didn't look like this PR was enough, so we disabled the flags.

TristanCacqueray avatar May 29 '24 12:05 TristanCacqueray

Well, after fixing this build, I realized large-records was added transitively by proto3-suite through an optional flags, and it didn't look like this PR was enough, so we disabled the flags.

Oooh hadn't realised that. proto3-suite is also how large-records ends up in my dependency tree, and my current workaround is pointing at this PR, might look into the flag instead.

Anedoctal, but I was using nixpkgs' 9.4 package set until a couple weeks ago and at least with my specific dependencies this PR allows building large-records (and thus proto3-suite) on 9.6. I'm pointing directly to it, skipping #152, but that requires callCabal2nix, which can't be used in nixpkgs, so no upstreaming option there either.

alexfmpe avatar May 29 '24 12:05 alexfmpe

Closed in favour of #156. See discussion and acknowledgements there :)

edsko avatar May 30 '24 07:05 edsko