Wei Zhou

Results 496 comments of Wei Zhou
trafficstars

> > lots of refactoring. I am not sure if the code is good or not. Maybe others can check. > > @stephankruggg can you point out the key point...

@shwstppr I am not sure if we should disallow the operation. would it be a valid use case for users to - drain the node in CKS - remove the...

> > @shwstppr I am not sure if we should disallow the operation. > > would it be a valid use case for users to > > ``` > >...

> @weizhouapache on the special case discussed earlier, @Pearl1594 made me aware that we already have an option with scaleKubernetesCluster API to delete a specific node using `nodeids` param. We...

@rajujith @shwstppr @DaanHoogland @sureshanaparti according to the source code, it looks featured templates must be public ![image](https://github.com/apache/cloudstack/assets/57355700/aaf0309c-8937-44b7-bff0-deab3ed3f2c6) https://github.com/apache/cloudstack/blob/4.19.0.1/api/src/main/java/com/cloud/template/VirtualMachineTemplate.java#L71-L80

> The improvement required here is to implement featured private template types where a user wants to list private /non public templates as featured. THANKS @rajujith can you suggest the...

thanks @rajujith since this is an improvement, moving to 4.20.0.0

> @weizhouapache can we extend the featured feature (bad pun unintended) to include the callers featured private templates, or should it really be a separate feature? @DaanHoogland I would suggest...

there is a related but different issue: #7483

> Hello @weizhouapache > > You can check PR #6460 that explains why the LB traffic is not blocked with ACL rules and how to achieve that. thanks @GutoVeronezi for...