Moshe Weitzman

Results 316 comments of Moshe Weitzman

Unfortunately I dont have time to test phpstan-drupal with the PR. And Drush no longer uses drupal-finder.

The requirement check only stops for interactive requests. Passing -y makes it non-interactive. This could be changed now that we have a new major version (13).

I'm going to call this 'By Design'. The behavior you seek happens when you pass --no-interaction instead of of --yes. --yes is like passing --no-interaction with the addition of auto-replying...

Drush is currently more permissive than the core UI. I think there is an argument for and against that.

If the queue worker logs messages, are they still shown? If so, I think this LGTM

Thanks. I'm also curious about any drush log messages that come from the worker. Maybe thats too uncommon to care about. The screenshot should also show the total number of...

Thats super ugly IMO. Once a progress bar starts repeating lines it loses its value IMO. Happy to discuss more.

Right, there isnt. a great alternative. And thats why this command hasnt been made a progress bar for years. The other two commands you mention were converted by eager contributors,...

Makes sense. I'm not sure how far we should take config edit functionality. For example, we have config:set and config:edit which also perform no validation.

Ideally Drupal core would provide a service for retrieving the changelist, similar to \Drupal\Core\Config\StorageComparer. Without the service, Drush has to get a bit tangled with the implementation.