Wei Qing

Results 49 comments of Wei Qing

Hi @leojiangxd, do fix the failing checks. You can click on 'Details' to see more information. In particular, it seems like the lint check (`npm run lint`) and the [snapshot...

@cedricongjh @kevin9foong ping for review

Hey @suneelval, can you take a look at the failing E2E test? It's the one at `InstructorSessionIndividualExtensionPageE2ETest`. Do ping me if you face any issues, and I'll also have a...

Hi @Sho-Shoo, we normally recommend issues tagged with `good first issue` for first-time contributors. However, if you're confident of tackling this issue, you can go ahead and submit a PR...

Hi @mud1tx, you can find the `sortable-table` component files and look through them to see what they do and how they do it. As an overview, the `sortable-table` component, as...

> Hi, I'll be taking up the Instructor courses page. Hope that's okay? Sure, do note the changes to the `sortable-table` component that was introduced in #12501

Thanks @domoberzin! Good catch

Hi @rahulpro2001, if I'm not wrong, the comment button is being picked up by the screen reader correctly. You can enable your own screen reader to check. I'm on mac,...

> @weiquu can we change the order of buttons or not? Hi @rahulpro2001, please change the order the _screen reader_ picks up the buttons, but do not change the visual...

Hi @willzoo, sure please feel free to submit a PR for this issue