Wei Ji

Results 343 comments of Wei Ji

> The [documentation of xarray accessor](https://docs.xarray.dev/en/stable/internals/extending-xarray.html) explains why they don't work as expected: > > > Accessors are created once per DataArray and Dataset instance. New instances, like those created...

Just wanted to say, this is a similar issue to that in the RAPIDS AI `cuml` library. See https://docs.rapids.ai/api/cuml/0.19/api.html#output-data-type-configuration. Their solution is to: 1. By default: 'mirror' the input data...

You're right that controlling the output type via a parameter (similar to what @willschlitzer did in bf58dc2defc3b6ff67e4769322505d63e4ad941d) would be simpler than a context manager. I don't have a preference for...

The return_table function looks to be on the right track. We can discuss this in the meeting tomorrow (https://forum.generic-mapping-tools.org/t/pygmt-community-zoom-meeting-tuesday-15-june-2021-utc-1700/1762) if there's time. In terms of your PRs #1284 and #1299...

> > When testing out the PR, I found it hard to remember 'a', 'd', and 's' (I kept instinctively trying 'p' for pandas.DataFrame). I would prefer longer names like...

> What's the reason for handling the return through temporary files versus creating a second virtual file to hold in-memory output? If there is a way to do that (store...

It's not very well documented, but we do have a [makecpt](https://www.pygmt.org/dev/api/generated/pygmt.makecpt.html#pygmt.makecpt) function as of #329. It actually works via `pygmt.makecpt` rather than `fig.makecpt`. Also GMT6 modern mode (which PyGMT uses)...

I agree that `pygmt.makecpt` could definitely be a lot better, it's not intuitive the way things work. Point 1: . Right now if you want to change to another colormap,...

Oh yes, you are welcome to add colorbars to both examples. Let me assign you to the issue, and thanks for volunteering to help out!