Wei Ji

Results 343 comments of Wei Ji

Nice, good to see those benchmarks! I've been wondering if we should use [pytest-benchmark](https://github.com/ionelmc/pytest-benchmark) to get an idea of speedup over time. There's this [`pytest-codspeed`](https://github.com/CodSpeedHQ/pytest-codspeed)/[CodSpeedHQ/action](https://github.com/CodSpeedHQ/action) tool that would allow us...

> * [ ] `x2sys_cross` I had a look at refactoring `x2sys_cross` to use virtualfiles instead of temporary files, but it's a little tricky because: - Input: Cannot pass in...

Hmm, a few things: 1. We should probably document that the lonlat range is from -180 to +180, or have a way of converting 0-360 coordinates to -180 to +180...

Thanks @yvonnefroehlich for writing up this detailed bug report! I can reproduce the error locally, and am wondering if this is a case of #896, whereby the 'plotting' function `grdimage`...

Gonna push some commits here to get the `load_blue_marble` function in for PyGMT v0.12.0.

Reopening because the histogram example mentioned in https://github.com/GenericMappingTools/pygmt/issues/2323#issuecomment-1383567307 hasn't been done yet, and we might want to add a full tutorial for bit/hachure patterns too.

> The failures are because `dtypes` is a list and is mutable, so changes in `dtypes` affect all later tests: Good spotting, I opened a PR at #2941 to fix...

Personally I do use type hints (and tried to add it to `pygmt.grdtrack` in 2019 apparently - https://github.com/GenericMappingTools/pygmt/pull/308#discussion_r287089810), but it can be a lot of work to add them across...