Wei Ji

Results 343 comments of Wei Ji

> > Oh yes, you are welcome to add colorbars to both examples. Let me assign you to the issue, and thanks for volunteering to help out! > > Thanks...

We'll need to discuss whether to add this. I recognize the value of using pre-commit, but I find that it is another layer of friction for new contributors to set...

Is it worth trying https://pre-commit.ci?

Another request from the forum at https://forum.generic-mapping-tools.org/t/how-to-plot-focal-mechanisme-cross-section-in-pygmt/3209. Looks like `coupe` is very in demand! Is anyone interested in implementing this in PyGMT? We've got some draft instructions on how to...

Right, so the code aliases `-G` as `fill`: https://github.com/GenericMappingTools/pygmt/blob/2ebe165373106d7bff5edcea3e5e09e077bc80b6/pygmt/src/histogram.py#L23 But we used `{G}` in the docstring here: https://github.com/GenericMappingTools/pygmt/blob/2ebe165373106d7bff5edcea3e5e09e077bc80b6/pygmt/src/histogram.py#L69 which means it shows up in the docs as `color`: https://github.com/GenericMappingTools/pygmt/blob/2ebe165373106d7bff5edcea3e5e09e077bc80b6/pygmt/helpers/decorators.py#L46-L47 ![image](https://user-images.githubusercontent.com/23487320/140869026-f98f1129-58e1-46bb-958c-6b96957228d2.png)...

> xref [GenericMappingTools/gmt#5563](https://github.com/GenericMappingTools/gmt/issues/5563) - I think we're leaning towards fill for GMT, but PyGMT already has color in plot and plot3d. Yeah, I think it would be nice to use...

> > I believe the documentation issue has been fixed by #2124. > > Now the question is, do we want to deprecate `color` in `plot` and `plot3d`, as suggested...

> I'm reopening the issue so that we won't forget to add some tests for this issue. Just for reference (since it took me a while to remember), we did...

Yet another half-yearly update. Upstream GMT issues to track this are at https://github.com/GenericMappingTools/gmt/issues/4335#issuecomment-709729148 and https://github.com/GenericMappingTools/gmt/issues/4440#issuecomment-724961749. Might be a longstanding issue with pixel registered grids?

No strong preference on which option to take, just as long as things are able to be standardized across the intake ecosystem like `to_dask` currently is. Maybe we could start...