cryptopp icon indicating copy to clipboard operation
cryptopp copied to clipboard

CRYPTOPP_VERSION has reached its limits

Open noloader opened this issue 9 months ago • 3 comments

Crypto++ 8.9.0 was released on October 1, 2023. As part of the release process, we bump version numbers for semantic versioning per https://www.cryptopp.com/wiki/Release_Versioning#Increment.

Crypto++ has a CRYPTOPP_VERSION macro, but it cannot handle '10' in the minor position. We cannot go from:

#define CRYPTOPP_VERSION 890

to version 8.10.

An additional constraint is, CRYPTOPP_VERSION has always used 10-based numbers. They are not hexadecimal based.

This report will track the problem.


$ grep CRYPTOPP_VERSION *.h *.cpp
config_ver.h:/// \sa CRYPTOPP_VERSION, LibraryVersion(), HeaderVersion()
config_ver.h:/// \sa CRYPTOPP_VERSION, LibraryVersion(), HeaderVersion()
config_ver.h:/// \sa CRYPTOPP_VERSION, LibraryVersion(), HeaderVersion()
config_ver.h:/// \details CRYPTOPP_VERSION reflects the version of the library the headers
config_ver.h:#define CRYPTOPP_VERSION 8A0
cryptlib.h:     return CRYPTOPP_VERSION;
bench1.cpp:     oss << "\n<H1><A href=\"http://www.cryptopp.com\">Crypto++ " << CRYPTOPP_VERSION / 100;
bench1.cpp:     oss << '.' << (CRYPTOPP_VERSION % 100) / 10 << '.' << CRYPTOPP_VERSION % 10 << "</A> Benchmarks</H1>";
cryptlib.cpp:# define CRYPTOPP_BUILD_VERSION CRYPTOPP_VERSION
test.cpp:                       std::cout << CRYPTOPP_VERSION / 100 << '.' << (CRYPTOPP_VERSION % 100) / 10 << '.' << CRYPTOPP_VERSION % 10 << std::endl;

noloader avatar Oct 01 '23 18:10 noloader